Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: incorporate code review changes #22

Merged
merged 22 commits into from
Mar 31, 2023
Merged

refactor: incorporate code review changes #22

merged 22 commits into from
Mar 31, 2023

Conversation

johnletey
Copy link
Member

No description provided.

johnletey and others added 19 commits March 20, 2023 11:05
@johnletey
feat(2.2.25): emit event when updating module params
8c7b246
@johnletey
chore(2.2.24): only import x/team keeper once
25cfa95
@johnletey
fix(2.2.11): validate msg inputs
199a36b
@mbreithecker
fix(2.2.19): inefficient check order
9b77d64
@mbreithecker
chore(2.2.23): avoid implicit memory aliasing
6402d4e
@johnletey
chore: sync main
2d9714e
@johnletey
refactor: switch relevant values to sdk.Dec (#19)
f09b544
@mbreithecker @johnletey
fix(2.2.7): improve commission when creating staker (#25)
0745e73 
Co-authored-by: John Letey <john@kyve.network>
@johnletey
Merge branch 'main' into john/review
5aaf937
@johnletey @mbreithecker
fix(2.2.14): improve error message
50a65d9
@mbreithecker
Merge remote-tracking branch 'origin/john/review' into john/review
1b996c3
@mbreithecker
fix(2.2.20): typographical errors
9e20764
@mbreithecker
fix(2.2.21): remove unused function
75508a3
@mbreithecker
fix(2.2.13): incorrect function descriptions in comments
f40a82e
@johnletey
chore(2.2.11): switch to validation helpers
e11e8b2
@mbreithecker
fix(2.2.1): use non-manipulable pseudo-random source seed
3a80f5f
@johnletey
chore(2.2.16): validate pool parameters better
5ec247b
@mbreithecker
chore(2.2.16): validate update msg and add more tests
b7777a7
@mbreithecker
chore(2.2.17): ensure UploadTimeout and MaxPoints are positive numbers
52981ae
@johnletey johnletey marked this pull request as ready for review March 30, 2023 13:13
mbreithecker
mbreithecker previously approved these changes Mar 30, 2023
View reviewed changes
@troykessler
Copy link
Member

Please update the spec files in each module accordingly. This includes the new eventEventUpdateParams in each module and the updated tx signature of MsgCreateStaker (commission arg)

mbreithecker
mbreithecker previously approved these changes Mar 31, 2023
View reviewed changes
troykessler
troykessler previously approved these changes Mar 31, 2023
View reviewed changes
@johnletey johnletey dismissed stale reviews from troykessler and mbreithecker via 2c6a813 March 31, 2023 08:05
@johnletey johnletey merged commit 5e7292e into main Mar 31, 2023
@johnletey johnletey deleted the john/review branch March 31, 2023 08:08
@coderabbitai coderabbitai bot mentioned this pull request May 6, 2024
Merged
@coderabbitai coderabbitai bot mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbreithecker mbreithecker mbreithecker approved these changes

@troykessler troykessler troykessler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnletey @troykessler @mbreithecker